test: use test context cleanup hooks in parser issue tests#5282
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5282 +/- ##
=======================================
Coverage 93.26% 93.26%
=======================================
Files 110 110
Lines 36533 36533
=======================================
Hits 34071 34071
Misses 2462 2462 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Needs rebase, and removal of Line 4 in bd98954 |
metcoder95
approved these changes
May 18, 2026
Member
Merging without rebase caused a lint failure which was fixed in #5316 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
N/A
Rationale
test/parser-issues.jswas using bareafter()calls even though the file only importstestfromnode:test. That caused lint failures (no-undef) and made the affected tests fail at runtime withReferenceError: after is not defined.Changes
tsplafter()calls withctx.after(...)in the affected parser issue testsFeatures
N/A
Bug Fixes
Breaking Changes and Deprecations
N/A
Status